From babc6ce21dd4810a1a0ffccb8ab5b587e2e8c2d5 Mon Sep 17 00:00:00 2001 From: Viktor Varland Date: Tue, 12 Nov 2019 17:12:04 +0100 Subject: [PATCH 1/3] fix(headerbar): fallback when api responds with blob --- src/HeaderBar/LogoImage.js | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/HeaderBar/LogoImage.js b/src/HeaderBar/LogoImage.js index 4566200..e8f277c 100644 --- a/src/HeaderBar/LogoImage.js +++ b/src/HeaderBar/LogoImage.js @@ -18,18 +18,27 @@ const query = { }, } +const pathExists = data => + data && + data.customLogo && + data.customLogo.images && + data.customLogo.images.png + export const LogoImage = () => { const { loading, error, data } = useDataQuery(query) if (loading) return null + let Logo + if (!error && pathExists(data)) { + Logo = Headerbar Logo + } else { + Logo = + } + return (
- {error ? ( - - ) : ( - Headerbar Logo - )} + {Logo} {defaultLogo.styles}
) From c271d1492db00006f4e39d76b34755786a2d76be Mon Sep 17 00:00:00 2001 From: Viktor Varland Date: Tue, 12 Nov 2019 17:41:32 +0100 Subject: [PATCH 3/3] refactor(headerbar): rename to logo styles --- src/HeaderBar/LogoImage.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/HeaderBar/LogoImage.js b/src/HeaderBar/LogoImage.js index d0cce6d..a31f4dd 100644 --- a/src/HeaderBar/LogoImage.js +++ b/src/HeaderBar/LogoImage.js @@ -5,7 +5,7 @@ import css from 'styled-jsx/css' import { useDataQuery } from '@dhis2/app-runtime' import { LogoIconWhite } from '@dhis2/ui-core' -const defaultLogo = css.resolve` +const logoStyles = css.resolve` svg { height: 25px; width: 27px; @@ -41,18 +41,18 @@ export const LogoImage = () => { Headerbar Logo ) } else { - Logo = + Logo = } return (
{Logo} - {defaultLogo.styles} + {logoStyles.styles}