This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix: don't break the layout when a data request fails #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that there's no reporting of the error in this case, but that's probably something we should handle in the Data Provider anyway (rather than in every data-wired component) |
varl
approved these changes
Jun 5, 2019
dhis2-bot
pushed a commit
that referenced
this pull request
Jun 5, 2019
## [1.0.4](v1.0.3...v1.0.4) (2019-06-05) ### Bug Fixes * don't break the layout when a data request fails ([#11](#11)) ([cb619c7](cb619c7))
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #7, but for errors - as a rule we shouldn't break component layout flow when waiting for data or indicating failed requests. I think generally we should just omit unloaded data unless there's a good UX alternative (tasteful spinners, red error border, etc)