Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(translations): add missing job types #493

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix(translations): add missing job types #493

merged 2 commits into from
Apr 19, 2023

Conversation

ismay
Copy link
Contributor

@ismay ismay commented Apr 18, 2023 •
edited
Loading

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Apr 18, 2023 •
edited
Loading

🚀 Deployed on https://pr-493--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify April 18, 2023 15:33 Inactive
@ismay ismay force-pushed the update-job-types branch from b385b7c to 1171823 Compare April 18, 2023 15:35
@dhis2-bot dhis2-bot temporarily deployed to netlify April 18, 2023 15:37 Inactive
@ismay ismay marked this pull request as ready for review April 18, 2023 15:41
@ismay ismay requested review from a team as code owners April 18, 2023 15:41
tomzemp
tomzemp approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I commented some word breaks which I wasn't sure were intentional or not

src/services/server-translations/jobTypesMap.js Outdated Show resolved Hide resolved
src/services/server-translations/jobTypesMap.js Outdated Show resolved Hide resolved
src/services/server-translations/jobTypesMap.js Outdated Show resolved Hide resolved
@ismay
Copy link
Contributor Author

ismay commented Apr 19, 2023

lgtm. I commented some word breaks which I wasn't sure were intentional or not

Yeah I wasn't sure about those either. I just directly converted the snakecase to sentence case.

@ismay
Copy link
Contributor Author

ismay commented Apr 19, 2023

Fixed the word spacing as @tomzemp suggested, I'll wait for CI to pass and merge.

@dhis2-bot dhis2-bot temporarily deployed to netlify April 19, 2023 09:59 Inactive
@ismay ismay merged commit 77d416a into master Apr 19, 2023
@ismay ismay deleted the update-job-types branch April 19, 2023 10:08
dhis2-bot added a commit that referenced this pull request Apr 19, 2023
@dhis2-bot
chore(release): cut 100.2.11 [skip release]
c2410fe 
## [100.2.11](v100.2.10...v100.2.11) (2023-04-19)

### Bug Fixes

* **translations:** add missing job types ([#493](#493)) ([77d416a](77d416a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.2.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomzemp tomzemp tomzemp approved these changes

@kabaros kabaros kabaros approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ismay @dhis2-bot @kabaros @tomzemp