Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-integrity): add indicator for slow checks #604

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

Birkbjo
Copy link
Member

@Birkbjo Birkbjo commented Mar 11, 2024

Adds an indicator to checks that have isSlow: true. The new UI in Data Administration separates these checks completely, because the user should be cautious when running these checks. So I think it's quite important to distinguish those here as well.

@Birkbjo Birkbjo requested review from a team as code owners March 11, 2024 16:07
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 11, 2024

🚀 Deployed on https://pr-604--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify March 11, 2024 16:12 Inactive
@Birkbjo Birkbjo requested a review from ismay March 11, 2024 21:03
}

.transferOption {
display: flex;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to flex, mostly because I prefer using gap instead of margins for spacing between the header and other stuff.

@dhis2-bot dhis2-bot temporarily deployed to netlify March 13, 2024 13:23 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 13, 2024 13:29 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 13, 2024 13:56 Inactive
@Birkbjo Birkbjo merged commit a4b7802 into master Mar 13, 2024
9 checks passed
@Birkbjo Birkbjo deleted the fix/data-integrity-slow-check-indicator branch March 13, 2024 14:46
dhis2-bot added a commit that referenced this pull request Mar 13, 2024
## [101.5.2](v101.5.1...v101.5.2) (2024-03-13)

### Bug Fixes

* **data-integrity:** add indicator for slow checks ([#604](#604)) ([a4b7802](a4b7802))
* **data-integrity:** change default report type to summary ([#603](#603)) [defer release] ([1e27b04](1e27b04))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants