feat: add edit sequence route

[ismay]

https://dhis2.atlassian.net/browse/DHIS2-15668

This adds the scheduler edit sequence route. For testing:

• locally the route is http://localhost:3000/#/edit-sequence/{sequence-id}.
• On debug 2.40 I've created a sequence and a couple jobs for testing: http://localhost:3000/#/edit-sequence/RWcaltWoKuN.
• Since the sequence gets its id from the first job, any sequence that has job 1 as the first job will have that id.

Note that the some of the patterns used are things we might want to refactor later. I've stuck with the existing approach to maintain the consistency of the code until then.

Todo

• Resize observer crash
• Discard form state lifting (maybe remove discard button from outside of form)
• Remove outdated comments
• Check missing elements compared to edit job route (details area, etc.)
  • Title to Sequence: {name}
  • Sequence details (created, last run) (don't have that info: https://dhis2.stoplight.io/docs/dhis2/362efac6198ea-get-a-scheduler)
  • Delete sequence button
• Update tests
  • Delete sequence modal
  • Delete sequence button
  • SequenceEditForm
  • SequenceEditFormContainer
• Check necessity of initialValues reduce (replace with simpler approach)

Backend

• https://dhis2.stoplight.io/docs/dhis2/6c6eff62bea73-delete-a-scheduler-queue, delete sequence does not work when sending a DELETE without a request body (responds with not found). app-runtime does not support a request body for DELETE requests. https://dhis2.slack.com/archives/CPGUFVC56/p1690972070298669

Follow up

• https://dhis2.atlassian.net/browse/DHIS2-15669
• https://dhis2.atlassian.net/browse/DHIS2-15670
• https://dhis2.atlassian.net/browse/DHIS2-15671
• https://dhis2.atlassian.net/browse/DHIS2-15672
• https://dhis2.atlassian.net/browse/DHIS2-15673
• https://dhis2.atlassian.net/browse/DHIS2-15677
• https://dhis2.atlassian.net/browse/DHIS2-15678

[dhis2-bot]

🚀 Deployed on https://pr-550--dhis2-scheduler.netlify.app

[ismay]

Btw. @tomzemp, for testing I recommend debug/dev. Hella found out that 2.40 has a bug that has been resolved in dev.

[helladawit]

Tested successful on version 2.41

[ismay]

Also @tomzemp, if you want to test the UI:

• Go to https://pr-550--dhis2-scheduler.netlify.app/#/add-sequence/
• Set a name, a cron expression and add at least two jobs to the sequence
• Click save
• After saving you'll be taken to the job overview
• You'll see the newly created sequence here as well
• Click actions > edit on the newly created sequence
• This will take you to the job edit screen, with a URL like https://pr-550--dhis2-scheduler.netlify.app/#/edit/xkxSSOLKc7X.
• Once there, change the edit in the URL to edit-sequence . So for example, from https://pr-550--dhis2-scheduler.netlify.app/#/edit/xkxSSOLKc7X to https://pr-550--dhis2-scheduler.netlify.app/#/edit-sequence/xkxSSOLKc7X

And then you'll have a new sequence to edit

[tomzemp]

Looks good! I don't have many line-by-line comments, but a couple of things I noticed / had questions about:

• Clicking edit for a sequence from the overview scheduled jobs list sends you to the edit job page, rather than the edit-sequence page. I assume that's going to be changed later?
• the useJobScheduleById hook only seems to be used for the job sequences, so would it make sense to rename to useJobSequenceById?
• the useJobSchedules hook is reassigning the id of the first job to the overall schedule (I understand this is a workaround for the fact that the backend isn't creating an id for the overall sequence/schedule), but this has the effect of making schedules with only one job accessible from the edit-sequence page. Maybe if useJobScheduleById becomes more explicitly for sequences, it should have logic to return an error if the sequence only has one job (in which case, it wouldn't be a sequence but a job)?

[ismay]

Thanks!

• Clicking edit for a sequence from the overview scheduled jobs list sends you to the edit job page, rather than the edit-sequence page. I assume that's going to be changed later?

Definitely. When updating the list view I'll update the edit button for sequences as well.

• the useJobScheduleById hook only seems to be used for the job sequences, so would it make sense to rename to useJobSequenceById?

Yeah the wording is a bit messed up atm. I created this issue for it: https://dhis2.atlassian.net/browse/DHIS2-15671. I could tackle that before merging.

• the useJobSchedules hook is reassigning the id of the first job to the overall schedule (I understand this is a workaround for the fact that the backend isn't creating an id for the overall sequence/schedule), but this has the effect of making schedules with only one job accessible from the edit-sequence page. Maybe if useJobScheduleById becomes more explicitly for sequences, it should have logic to return an error if the sequence only has one job (in which case, it wouldn't be a sequence but a job)?

Yeah this is a bit confusing conceptually. So the schedules are a mix of jobs and queues. A schedule with one item in the sequence is a job, and a schedule with multiple items in the sequence is a queue. Conceptually schedules are there for both jobs and queues. The idea being that it simplifies displaying both types in the overview. I've collected this and other api quirks I've encountered so far here: https://dhis2.atlassian.net/browse/DHIS2-15669. Let me know what you think of that.

[ismay]

Thanks for the review @helladawit & @tomzemp

[dhis2-bot]

🎉 This PR is included in version 101.2.0 🎉

The release is available on:

• AppHub release
• GitHub release

Your semantic-release bot 📦🚀