fix: use parent container for fullscreen map (DHIS2-8524) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
Mar 25, 2020
dhis2-bot
added a commit
that referenced
this pull request
Mar 25, 2020
## [1.0.17](v1.0.16...v1.0.17) (2020-03-25) ### Bug Fixes * use parent container for fullscreen map (DHIS2-8524) ([#77](#77)) ([e1290d6](e1290d6))
|
🎉 This PR is included in version 1.0.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-8524
Related PR for Maps app: dhis2/maps-app#522
The default behaviour of the fullscreen control is to open the map container in fullscreen. As we also want to include other elements like map title, it's better to use the 2x parent component. This is the same we already use for plugin/dashboard maps, so it simplifies the code.
Split view maps (which consists of multiple maps still need to move one level up in the DOM hierarchy).
The PR also includes a style fix for split view map controls which had a transparent hover style which should be solid.
Before:
After:
