fix: trigger cluster update when new cluster tiles are loaded (DHIS2-8498) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Bjørn, I set up the branch locally and I'm still able to see the bug. It doesn't always happen, just sometimes. If i click a second time on the "zoom to content" button, then the extra clusters are removed. |
|
I've pushed a new fix. The issue is that we rely on the underlying tile handling of Mapbox GL JS, and these tiles are not always updated when the "moveend" event is fired. The new fix checks if the visible tiles of the map aligns with the current zoom level. If not it will wait until this is the case. |
martinkrulltott
approved these changes
Mar 23, 2020
|
Looks all good to me, maybe @jenniferarnesen wants to retest and verify before merging though. 👍 |
dhis2-bot
added a commit
that referenced
this pull request
Mar 24, 2020
## [1.0.15](v1.0.14...v1.0.15) (2020-03-24) ### Bug Fixes * trigger cluster update when new cluster tiles are loaded (DHIS2-8498) ([#70](#70)) ([4e7ec77](4e7ec77))
|
🎉 This PR is included in version 1.0.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-8498
When the app or user is quickly zooming the map, the cluster tiles are not yet ready to update. The result is that some clusters remains on the map. The issue is fixed by calling the onMoveEnd method every time a cluster tile is changed.
Screenshot showing the original issue:
Screen recording showing that the map is properly updated:
