fix: index and ordering for layer groups (DHIS2-8496) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Mar 19, 2020
## [1.0.14](v1.0.13...v1.0.14) (2020-03-19) ### Bug Fixes * index and ordering for layer groups ([#69](#69)) ([00bc7d0](00bc7d0))
|
🎉 This PR is included in version 1.0.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-8496
The tracked entities layer uses "layer group" as it contains both points, lines and polygons. The layer group didn't have the
setIndexmethod, only the individual layers.Error shown in the console:
The method is called from the maps app:
https://github.com/dhis2/maps-app/blob/master/src/components/map/Layer.js#L123
This PR adds the
setIndexmethod, and calls the same method on each sublayer.There are no code changes in Layer.js (only prettifier).
The PR also includes a fix for the removeFrom(map) method.
Tracked entities shown above a thematic map:
Tracked entities shown below a thematic map: