feat: highlight multiple features with same string id (DHIS2-11969) #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
approved these changes
Feb 23, 2022
dhis2-bot
added a commit
that referenced
this pull request
Feb 23, 2022
# [3.1.0](v3.0.9...v3.1.0) (2022-02-23) ### Features * highlight multiple features with same string id ([#447](#447)) ([3a3f65e](3a3f65e))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows multiple features with the same id to be highlighted (hover state). It will be used for the upcoming "catchment area" support when the same org unit can be represented by two geometries (point and polygon).
Partly fixes: https://jira.dhis2.org/browse/DHIS2-11969
This change is backwards compatible with the Maps app, which still calls the "highlight" method with the org unit id for the layer in use.
Screen recording showing how both a point and a polygon will be highlighted:
