fix: don't set opacity before layer is added to map #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
Mar 11, 2021
| @@ -415,7 +415,7 @@ class EarthEngine extends Layer { | |||
| const layerId = `${id}-polygon` | |||
| const mapgl = this.getMapGL() | |||
|
|
|||
| if (mapgl.getLayer(layerId)) { | |||
| if (mapgl && mapgl.getLayer(layerId)) { | |||
There was a problem hiding this comment.
Suggested change
| if (mapgl && mapgl.getLayer(layerId)) { | |
| if (mapgl?.getLayer(layerId)) { |
There was a problem hiding this comment.
I agree, but I don't take the risk on hard freeze day - need do be sure that it's supported by the babel setup first.
dhis2-bot
added a commit
that referenced
this pull request
Mar 11, 2021
## [1.8.4](v1.8.3...v1.8.4) (2021-03-11) ### Bug Fixes * don't set opacity before layer is added to map ([#298](#298)) ([a05e04a](a05e04a))
|
🎉 This PR is included in version 1.8.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids an app crash when the opacity is changed before the layers are added to the map. There will be a separate PR in
maps-appwhen this PR is merged.