feat: improve multitouch handling (DHIS2-10413) #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Feb 25, 2021
dhis2-bot
added a commit
that referenced
this pull request
Feb 25, 2021
# [1.7.0](v1.6.0...v1.7.0) (2021-02-25) ### Features * improve multitouch handling (DHIS2-10413) ([#276](#276)) ([e2b82cc](e2b82cc))
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes: https://jira.dhis2.org/browse/DHIS2-10413
The mapbox-gl-multitouch dependency we used has been deprecated by the author (https://www.npmjs.com/package/mapbox-gl-multitouch), so I copied the code into the repo and made some smaller adjustments.
We use multitouch as an alternative to one finger panning on dashboard maps, to avoid a "page scroll trap". We're no longer enabling multitouch by default - it kan be turned on and off with the new
toggleMultiTouch(isEnabled)method. This allows us to disable one finger panning for dashboard maps, but enable it in fullscreen mode.