From 09fcae0d2fb0671c0d60acfa436201d5dee2137a Mon Sep 17 00:00:00 2001 From: Ilya Nee Date: Fri, 12 Apr 2019 15:22:26 +0200 Subject: [PATCH] Use deep equality check for plugin props --- packages/plugin/src/ChartPlugin.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/plugin/src/ChartPlugin.js b/packages/plugin/src/ChartPlugin.js index eb43c8989a..7adf44b35c 100644 --- a/packages/plugin/src/ChartPlugin.js +++ b/packages/plugin/src/ChartPlugin.js @@ -1,6 +1,6 @@ import React, { Component, Fragment } from 'react'; import PropTypes from 'prop-types'; - +import isEqual from 'lodash-es/isEqual'; import { createChart } from 'd2-charts-api'; import { apiFetchVisualization } from './api/visualization'; @@ -32,12 +32,12 @@ class ChartPlugin extends Component { } componentDidUpdate(prevProps) { - if (this.props.config !== prevProps.config) { + if (!isEqual(this.props.config, prevProps.config)) { this.renderChart(); return; } - if (this.props.filters !== prevProps.filters) { + if (!isEqual(this.props.filters, prevProps.filters)) { this.renderChart(); return; }