Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Fix app height calculation #494

Closed
amcgee opened this issue Nov 28, 2019 · 3 comments
Closed

TODO: Fix app height calculation #494

amcgee opened this issue Nov 28, 2019 · 3 comments
Assignees
@amcgee
Labels
released

Comments

@amcgee
Copy link
Member

amcgee commented Nov 28, 2019

As of #327 it overflows the bottom edge of the page. This should be fixed in the shell and correctly inherited by the app.
@amcgee amcgee mentioned this issue Jan 16, 2020
Merged
@amcgee amcgee self-assigned this Jan 16, 2020
@amcgee amcgee mentioned this issue Jan 16, 2020
Merged
@amcgee
Copy link
Member Author

amcgee commented Jan 27, 2020

Fixed in #550 - not sure why this didn't close automatically...

@amcgee amcgee closed this as completed Jan 27, 2020
@amcgee
Copy link
Member Author

amcgee commented Jan 27, 2020

Ah, because it's not in master 👍

@dhis2-bot
Copy link
Contributor

🎉 This issue has been resolved in version 33.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcgee amcgee

Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amcgee @dhis2-bot