fix: allow apps to opt out of plugin logic [LIBS-579] #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVandivier
approved these changes
Apr 29, 2024
dhis2-bot
added a commit
that referenced
this pull request
May 6, 2024
## [11.2.2](v11.2.1...v11.2.2) (2024-05-06) ### Bug Fixes * allow apps to opt out of plugin logic [LIBS-579] ([#833](#833)) ([d450758](d450758))
|
🎉 This PR is included in version 11.2.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to apps to skip the PluginLogic (post-robot communciations and styling for implementing resizing logic) of app-platform). See https://dhis2.atlassian.net/jira/software/c/projects/LIBS/issues/LIBS-579
If property
skipPluginLogic: trueis added in d2.config.js, this will be skipped. By default, the PluginLogic will be implemented, but in cases where this is unnecessary for a plugin or potentially problematic (Maps app), this can be disabled.Note in maps app, there is an apparent conflict between the app-platform PluginLogic component's resizing logic and the styling in the maps app (which caused the map plugin to not display properly).