fix: set default value for all strings #552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default value will be set for every string. if no default value is specifically provided, then the key will be used. The end result is that the generated
en.pot
file contains translations for every string. This pot file is then accepted by transifex, allowing plurals to be properly translated. (after much trial and error together with Phil, we found that Transifex will not parse the imported pot file if only some of the strings have values)d2-ui/interpretations currently uses this modified version of the extract.js script and it works as expected: https://github.com/dhis2/d2-ui/blob/master/packages/interpretations/scripts/extract.js
Would it be possible to release a beta to be tested with the DV app?
Here is an example of how plurals would look in code:
(https://github.com/dhis2/d2-ui/blob/master/packages/interpretations/src/components/Interpretation/Replies.js#L73)