Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): let init produce app using css-modules instead of styled-jsx #417

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

HendrikThePendric
Copy link
Contributor

No description provided.

@HendrikThePendric HendrikThePendric requested a review from amcgee June 10, 2020 08:25
@HendrikThePendric HendrikThePendric self-assigned this Jun 10, 2020
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bug

cli/config/init.entrypoint.js Outdated Show resolved Hide resolved
cli/src/commands/init.js Show resolved Hide resolved
@HendrikThePendric HendrikThePendric force-pushed the use-css-modules-in-initialized-app branch from 67fbdd0 to f43fd65 Compare June 10, 2020 08:37
@HendrikThePendric HendrikThePendric requested a review from amcgee June 10, 2020 08:40
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but LGTM!

@amcgee amcgee changed the title fix(cli): let init produce app using css-modules instead of styled-jsx fix(init): let init produce app using css-modules instead of styled-jsx Jun 10, 2020
@HendrikThePendric HendrikThePendric merged commit 0c8c314 into master Jun 10, 2020
@HendrikThePendric HendrikThePendric deleted the use-css-modules-in-initialized-app branch June 10, 2020 09:55
dhis2-bot added a commit that referenced this pull request Jun 10, 2020
## [4.0.8](v4.0.7...v4.0.8) (2020-06-10)

### Bug Fixes

* **cli:** let init produce app using css-modules instead of styled-jsx ([#417](#417)) ([0c8c314](0c8c314))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants