Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP Headers #18

Closed
OuiSouss opened this issue Apr 2, 2024 · 6 comments
Closed

Add support for HTTP Headers #18

OuiSouss opened this issue Apr 2, 2024 · 6 comments
Assignees

Comments

@OuiSouss
Copy link

OuiSouss commented Apr 2, 2024

Hello,

First of all, I'd like to thank you for this very useful tool.

I've just tested the tool a little. I have the impression that it's not possible to set HTTP headers to query the production URL.

For example, I have a TrueNas Scale at home and to get its version, it is necessary to use HTTP API with HTTP header Authorization.

Did I miss something or is it a real request feature ?

@luclu7
Copy link
Contributor

luclu7 commented Apr 3, 2024

Hello, I don't think it's currently possible. It could be added, if you can!

@dhenry123
Copy link
Owner

Thank you for your interest,
Your request has been accepted and will be available soon.
+++

@dhenry123 dhenry123 self-assigned this Apr 4, 2024
@dhenry123
Copy link
Owner

Hello @OuiSouss

Hello, what type of deployment are you using, legacy or container? I'd like to prepare a pre-release that you could test (there will be no impact on your current data).
Do you agree?

I need to do some testing, so I think it'll be ready the day after tomorrow.
+++

image

@OuiSouss
Copy link
Author

Thanks a lot (sorry I did not see the message). It's perfect, I will update the container.

@dhenry123
Copy link
Owner

Thanks for the feedback!

@dhenry123
Copy link
Owner

dhenry123 commented Jul 3, 2024

Hi @OuiSouss
I'm using this feature for the first time to check the version of dataplane haproxy API, which requires authentication.
When the new control was created, the version request was OK. Once the control had been saved, I clicked on the "compare" button and got a 401 error.
After checking my code, the method responsible for making the comparison does not implement the authentication header.
I'm in the process of fixing it, and a new version will be available soon.
+++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants