Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode() can read past the end of the slice #1

Open
dgryski opened this issue Feb 15, 2017 · 1 comment
Open

Decode() can read past the end of the slice #1

dgryski opened this issue Feb 15, 2017 · 1 comment

Comments

@dgryski
Copy link
Owner

dgryski commented Feb 15, 2017

The Go code always does a uint32 read, which if the last number is only a single can can read past the end of the slice.

The SSE code always reads 16 bytes past the initial header byte before shuffling the numbers appropriate.

These should be documented as least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@dgryski and others