Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench fails to build #34

Closed
h8liu opened this issue Aug 2, 2019 · 3 comments
Closed

bench fails to build #34

h8liu opened this issue Aug 2, 2019 · 3 comments
Assignees
@karlmcguire
Labels
kind/bug Something is broken.

Comments

@h8liu
Copy link

h8liu commented Aug 2, 2019 

# github.com/dgraph-io/ristretto/bench
src/github.com/dgraph-io/ristretto/bench/bench.go:325:10: undefined: ristretto.PolicyLog

Found by gopkgs.io
@karlmcguire
Copy link
Contributor

Thanks for the heads up. We just overhauled the hit ratio tracking in Ristretto so I'm going to have to decouple bench and add my own tracking. Give me a few hours.

@karlmcguire karlmcguire self-assigned this Aug 2, 2019
@karlmcguire karlmcguire added the kind/bug Something is broken. label Aug 2, 2019
@manishrjain
Copy link
Contributor

Sorry for the breakage. Did the change late night and was more focused on the performance and coverage. Thanks Karl for taking care of it.

@karlmcguire karlmcguire mentioned this issue Aug 14, 2019
Merged
@karlmcguire
Copy link
Contributor

Fixed in #35.

@karlmcguire karlmcguire mentioned this issue Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlmcguire karlmcguire

Labels
kind/bug Something is broken.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@h8liu @manishrjain @karlmcguire