Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug to support using json files in the bulk loader #3464

Merged
merged 2 commits into from
May 23, 2019

Conversation

gitlw
Copy link

@gitlw gitlw commented May 23, 2019

This change is Reviewable

@gitlw
Copy link
Author

gitlw commented May 23, 2019

Fixes #3462

@gitlw gitlw requested review from a team and manishrjain May 23, 2019 18:50
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @gitlw and @manishrjain)


dgraph/cmd/bulk/run.go, line 100 at r1 (raw file):

func ensureExists(file string) {
	if _, err := os.Stat(file); err != nil && os.IsNotExist(err) {
		fmt.Fprintf(os.Stderr, "Path(%v) does not exist.\n", file)

nit: add a space after Path


dgraph/cmd/bulk/run.go, line 145 at r1 (raw file):

		os.Exit(1)
	case opt.RDFDir != "" && opt.JSONDir != "":
		fmt.Fprintf(os.Stderr, "Invalid flags: only one of rdfs(%q) of jsons(%q) may be specified.\n",

While you are fixing this file, can you fix this error message? I think it should say:

		fmt.Fprintf(os.Stderr, "Invalid flags: only one of rdfs (%q) or jsons (%q) may be specified.\n",
			opt.RDFDir, opt.JSONDir)

@gitlw gitlw merged commit 1e47988 into release/v1.0 May 23, 2019
@gitlw gitlw deleted the gitlw/fix_bl_json branch May 23, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants