When calculating a snapshot, retrieve entries in batches. #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculating a snapshot can lead to an OOM issue since the entries might not be able to fit into memory. This PR changes to logic to instead retrieve the entries in batches of 64MB.
manishrjain
suggested changes
May 14, 2019
There was a problem hiding this comment.
Nice. Got a few comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)
worker/draft.go, line 1255 at r1 (raw file):
batchSize = 64 * (1 << 20) batchFirst := first for batchFirst < last+1 {
for first <= last {
}
worker/draft.go, line 1256 at r1 (raw file):
batchFirst := first for batchFirst < last+1 { entries, err := n.Store.Entries(batchFirst, last+1, batchSize)
s/batchSize/64<<20
s/batchFirst/first
manishrjain
approved these changes
May 14, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)
worker/draft.go, line 1301 at r2 (raw file):
// It is possible that there are no pending transactions. In that case, // snapshotIdx would be zero. if foundEntries {
No need for this var.
martinmr
added a commit
that referenced
this pull request
May 14, 2019
Calculating a snapshot can lead to an OOM issue since the entries might not be able to fit into memory. This PR changes to logic to instead retrieve the entries in batches of 64MB.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…3409) Calculating a snapshot can lead to an OOM issue since the entries might not be able to fit into memory. This PR changes to logic to instead retrieve the entries in batches of 64MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating a snapshot can lead to an OOM issue since the entries might
not be able to fit into memory. This PR changes to logic to instead
retrieve the entries in batches of 64MB.
This change is