Make uid function work with value variables in upsert blocks #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, only variables containing UIDs (e.g. `uid as uid`) work correctly when used in upsert blocks with the `uid` function. With this fix, all variables (e.g. `value as value`) work appropriately, as we fetch the list of UIDs from the keys in the value map when needed. Fixes #4424
martinmr
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Other than the test you are working on and a minor comment it
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @campoy and @manishrjain)
edgraph/server.go, line 763 at r1 (raw file):
// If the list of UIDs is empty but the map of values is not, // we need to get the UIDs from the keys in the map.
minor: this probably fits in a single line. Ignore if it doesn't.
danielmai
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @campoy and @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only variables containing UIDs (e.g.
uid as uid) work correctlywhen used in upsert blocks with the
uidfunction.With this fix, all variables (e.g.
value as value) work appropriately, as wefetch the list of UIDs from the keys in the value map when needed.
Fixes #4424
This change is