Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close store after stoping worker #4356

Merged
merged 1 commit into from
Dec 6, 2019
Merged

close store after stoping worker #4356

merged 1 commit into from
Dec 6, 2019

Conversation

poonai
Copy link
Contributor

@poonai poonai commented Dec 5, 2019 •
edited by sleto-it
Loading

Reference:

Signed-off-by: பாலாஜி [email protected]

This change is Reviewable

close store after stoping worker
f4f66d2 
Signed-off-by: பாலாஜி <[email protected]>
@poonai poonai requested review from manishrjain and a team as code owners December 5, 2019 06:05
@poonai poonai requested a review from martinmr December 5, 2019 06:05
manishrjain
manishrjain approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @martinmr)

@poonai poonai merged commit 95c5865 into master Dec 6, 2019
@jarifibrahim jarifibrahim mentioned this pull request Dec 17, 2019
Closed
@joshua-goldstein joshua-goldstein deleted the balaji/close branch August 11, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain approved these changes

@martinmr martinmr Awaiting requested review from martinmr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poonai @manishrjain