Don't delete group if there is no member in the group

[poonai]

Manually tested by having two alpha with 1 replica count. removed one alpha and joined a new alpha. Alpha joined back to the existing group as expected
Signed-off-by: பாலாஜி [email protected]

---

This change is 

[martinmr]

The group delete test is not passing anymore (since it's testing explicitly that groups are deleted). I suppose that test is obsolete if this PR is approved.

But you should write a similar test (or change the group delete test) to verify that groups are not deleted.

Also, what would happen to tablets that are assigned to an empty group? We should verify that empty groups are not assigned new tablets and that the existing tablets of a group with no members are removed before the group is empty (this might already be done when removing a group but I am not sure).

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)

[poonai]

@martinmr good catch about tablet. Lemme check and verify

[manishrjain]

Looks good to me. Leave it to @martinmr to approve.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[martinmr]

One comment regarding the test but feel free to merge once it's been addressed.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @balajijinnah)

---

systest/group-delete/group_delete_test.go, line 161 at r2 (raw file):

Quoted 4 lines of code…

	group, ok := state2.Groups["3"]
	if !ok {
		t.Errorf("group 3 is removed")
	}

Can you change this so we use the require library everywhere?

so this would become.

group, ok := state2.Groups["3"]
require.False(ok, "group 3 is removed")

Same for all the other instances of t.Errorf in this test.

[poonai]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)

---

systest/group-delete/group_delete_test.go, line 161 at r2 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

	group, ok := state2.Groups["3"]
	if !ok {
		t.Errorf("group 3 is removed")
	}

Can you change this so we use the require library everywhere?

so this would become.

group, ok := state2.Groups["3"]
require.False(ok, "group 3 is removed")

Same for all the other instances of t.Errorf in this test.

Done.