Vendor latest badger #4200
Merged
Vendor latest badger #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@jarifibrahim you can click here to see the review status or cancel the code review job.
jarifibrahim
pushed a commit
to dgraph-io/badger
that referenced
this pull request
Oct 21, 2019
The proto files in the current master are not compatible with the ones in dgraph. See build for PR dgraph-io/dgraph#4200 ``` [Step 3/5] # github.com/dgraph-io/dgraph/protos/pb [11:02:11] [Step 3/5] ../protos/pb/pb.pb.go:7146:29: m.Kv[iNdEx].MarshalToSizedBuffer undefined (type *pb.KV has no field or method MarshalToSizedBuffer) [11:02:11] [Step 3/5] ../protos/pb/pb.pb.go:7209:29: m.Kv[iNdEx].MarshalToSizedBuffer undefined (type *pb.KV has no field or method MarshalToSizedBuffer) [11:02:40] [Step 3/5] Makefile:66: recipe for target 'install' failed [11:02:40] [Step 3/5] make[1]: *** [install] Error 2 [11:02:40] [Step 3/5] make[1]: Leaving directory '/home/pawan0201/go/src/github.com/dgraph-io/dgraph/dgraph' [11:02:40] [Step 3/5] make: *** [install] Error 2 [11:02:40] [Step 3/5] Makefile:43: recipe for target 'install' failed [11:02:40] [Step 3/5] Process exited with code 2 ``` https://teamcity.dgraph.io/viewLog.html?buildId=29232&buildTypeId=Dgraph_Blockade&tab=buildLog This PR updates the proto files in badger. I've run `./gen.sh` script to regenerate these.
golangcibot
reviewed
Oct 29, 2019
jarifibrahim
changed the title
jarifibrahim
requested review from
manishrjain,
martinmr and
a team
as code owners
manishrjain
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Reviewed 6 of 53 files at r1, 49 of 49 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jarifibrahim and @martinmr)
manishrjain
pushed a commit
to outcaste-io/outserv
that referenced
this pull request
Jul 6, 2022
The proto files in the current master are not compatible with the ones in dgraph. See build for PR dgraph-io/dgraph#4200 ``` [Step 3/5] # github.com/dgraph-io/dgraph/protos/pb [11:02:11] [Step 3/5] ../protos/pb/pb.pb.go:7146:29: m.Kv[iNdEx].MarshalToSizedBuffer undefined (type *pb.KV has no field or method MarshalToSizedBuffer) [11:02:11] [Step 3/5] ../protos/pb/pb.pb.go:7209:29: m.Kv[iNdEx].MarshalToSizedBuffer undefined (type *pb.KV has no field or method MarshalToSizedBuffer) [11:02:40] [Step 3/5] Makefile:66: recipe for target 'install' failed [11:02:40] [Step 3/5] make[1]: *** [install] Error 2 [11:02:40] [Step 3/5] make[1]: Leaving directory '/home/pawan0201/go/src/github.com/dgraph-io/dgraph/dgraph' [11:02:40] [Step 3/5] make: *** [install] Error 2 [11:02:40] [Step 3/5] Makefile:43: recipe for target 'install' failed [11:02:40] [Step 3/5] Process exited with code 2 ``` https://teamcity.dgraph.io/viewLog.html?buildId=29232&buildTypeId=Dgraph_Blockade&tab=buildLog This PR updates the proto files in badger. I've run `./gen.sh` script to regenerate these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates version of badger to
v2.0.0in Dgraph.The cache size for Alpha WAL badger and Zero WAL badger instance is 10 MB.
For the Alpha posting badger, the default cache size is 1 GB.
This change is