Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Ensure that client can send OpenCensus spans over to the server #4144

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Bug Fix: Ensure that client can send OpenCensus spans over to the server #4144

merged 1 commit into from
Oct 9, 2019

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Oct 9, 2019 •
edited
Loading

This change is Reviewable

@manishrjain manishrjain requested a review from a team as a code owner October 9, 2019 02:31
pullrequest[bot]
pullrequest bot reviewed Oct 9, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

Check the status or cancel PullRequest code review here.

pullrequest[bot]
pullrequest bot reviewed Oct 9, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
✅ It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

danielmai
danielmai approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

danielmai
danielmai approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@manishrjain manishrjain merged commit 9961fe3 into master Oct 9, 2019
@manishrjain manishrjain deleted the mrjn/opencensus branch October 9, 2019 02:33
pullrequest[bot]
pullrequest bot reviewed Oct 9, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, and good to go.

Reviewed with ❤️ by PullRequest

mangalaman93 added a commit that referenced this pull request Oct 9, 2019
@mangalaman93
Fix tests broken by #4144
9bed079
mangalaman93 added a commit that referenced this pull request Oct 9, 2019
@mangalaman93
Fix tests broken by #4144 (#4147)
fce1819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

@danielmai danielmai danielmai approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manishrjain @danielmai