Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file permissions. #4088

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Fix file permissions. #4088

merged 2 commits into from
Oct 3, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Sep 27, 2019

Change file permissions when creating directories to 0750 and when creating files to 0600 for security reasons.


This change is Reviewable

Change file permissions when creating files and directories to 0750 for
security reasons.
@martinmr martinmr requested review from manishrjain and a team as code owners September 27, 2019 21:49
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@martinmr you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From observation, what you've done looks appropriate:

  • Readable, writeable and executable for the owner,
  • Readable and executable for anyone in the group,
  • Inaccessible to everyone else.

Reviewed with ❤️ by PullRequest

@martinmr martinmr merged commit 3e660fe into master Oct 3, 2019
@martinmr martinmr deleted the martinmr/fix-file-perms branch October 3, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant