Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x: increment loop variable #4036

Merged
merged 1 commit into from
Sep 24, 2019
Merged

x: increment loop variable #4036

merged 1 commit into from
Sep 24, 2019

Conversation

shawnps
Copy link
Contributor

@shawnps shawnps commented Sep 21, 2019 •
edited by manishrjain
Loading

I may be mistaken but it seems that i should be getting incremented in this loop rather than retries.

This change is Reviewable

@shawnps shawnps requested review from manishrjain and a team as code owners September 21, 2019 00:59
pullrequest[bot]
pullrequest bot reviewed Sep 21, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

@shawnps you can click here to see the review status or cancel the code review job.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mangalaman93
mangalaman93 approved these changes Sep 21, 2019
View reviewed changes
Copy link
Contributor

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

pullrequest[bot]
pullrequest bot reviewed Sep 21, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Let's ship it!

Reviewed with ❤️ by PullRequest

poonai
poonai approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@poonai poonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution <3

@mangalaman93 mangalaman93 self-assigned this Sep 24, 2019
manishrjain
manishrjain approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@manishrjain manishrjain merged commit 412831e into dgraph-io:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

@poonai poonai poonai approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@manishrjain manishrjain manishrjain approved these changes

Assignees

@mangalaman93 mangalaman93

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shawnps @CLAassistant @manishrjain @mangalaman93 @poonai