Fix the zero client in live loader to avoid using TLS in 1.0.x #3936
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@gitlw you can click here to see the review status or cancel the code review job.
|
Is this related to #3919? |
|
@gitlw please merge with latest release/v1.0 branch. Looks like this change was done on top of an older version, so the CI tests failed. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Change conforms to description, and seems like it fixes the issue referenced. Wondering if there's any additional test cases required?
Reviewed with ❤️ by PullRequest
since zero does not support TLS at this moment.
PS. this is not a issue in the master branch as there have been quite some changes around the TLS code.
This change is