Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: Vendor in latest Badger with data-format changes. #3906

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Sep 3, 2019

This change vendors in the latest Badger to bring in the vlog data format change made in dgraph-io/badger@fbcd608. This is a breaking change: Clusters running v1.1.0-rc3 or latest master must export/re-import the data into a new cluster as outlined in the Upgrade Database docs.

Full Badger changelist between vendored versions:
dgraph-io/badger@398445a...fbcd608

  • Vendor in latest Badger
  • Vendor in latest ristretto/z package (dependency of Badger)

This change is Reviewable

    govendor fetch github.com/dgraph-io/ristretto/z/...
@danielmai danielmai requested review from manishrjain and a team as code owners September 3, 2019 20:08
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@danielmai danielmai changed the title Vendor in latest Badger with data-format changes. Breaking change: Vendor in latest Badger with data-format changes. Sep 3, 2019
@danielmai danielmai merged commit f437d01 into master Sep 3, 2019
@danielmai danielmai deleted the danielmai/vendor-badger branch September 3, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants