Adding log lines to help troubleshoot snapshot and rollup #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@gitlw you can click here to see the review status or cancel the code review job.
| @@ -403,6 +403,7 @@ func (n *node) processRollups() { | |||
| return | |||
| case readTs = <-n.rollupCh: | |||
| case <-tick.C: | |||
| glog.V(3).Infof("Evaluating rollup readTs:%d last:%d rollup:%v", readTs, last, readTs > last) | |||
There was a problem hiding this comment.
You might want to add a space between all the : and the actual words for readability in the logtrace.
example readTs:%d -> readTs : %d
Ditto for the other log statement that was added in this PR.
martinmr
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gitlw and @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During troubleshooting it's sometimes useful to see that the snapshot and rollup logic are being evaluated, and know the decision of the evaluation. This PR adds the logs at verbose level 3 to help with the troubleshooting.
This change is