-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make --lru_mb optional #3850
Comments
Just an opinion, I think we should try catch the RAM available and set 50% of it as default. e.g (from stackoverflow) package main
// #include <unistd.h>
import "C"
func main() {
println(C.sysconf(C._SC_PHYS_PAGES)*C.sysconf(C._SC_PAGE_SIZE), " bytes")
} Or https://godoc.org/github.com/capnm/sysinfo If we set 1024MB as default users can think this is some kind of minimal recommendation. But the real recommendation is to use at least 50% of available RAM. |
I do not think |
I don't care that much about the value, but making it compulsory when we're not even using it seems unnecessary. Running the version on master as today I get:
|
After a chat with @manishrjain we decided that we should try to guess the total size of RAM and:
This will be part of the next release, not necessary for 1.1.0 |
* make lru_mb optional Fixes #3850 * applied Manish's feedback
Currently, alphas won't work unless you provide a value for
--lru_mb
of at least 1024MBWe should instead set the default to
1024MB
.The text was updated successfully, but these errors were encountered: