Bugfix: Set found to false to avoid deleting index edge when value doesn't match. #3843
Conversation
pawanrawal
requested review from
manishrjain,
martinmr and
a team
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@pawanrawal you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
This changes seems to match the description and nice job updating the unit tests to match the expected
functionality.
Reviewed with ❤️ by PullRequest
| @@ -331,7 +331,7 @@ func (txn *Txn) addMutationHelper(ctx context.Context, l *List, doUpdateIndex bo | |||
|
|
|||
| if pFound && !(bytes.Equal(currPost.Value, newPost.Value) && | |||
| types.TypeID(currPost.ValType) == types.TypeID(newPost.ValType)) { | |||
| return val, found, emptyCountParams, err | |||
| return val, false, emptyCountParams, nil | |||
There was a problem hiding this comment.
Would it be worth adding part of the comment from your PR description here just to help future readers of the code have that context? Otherwise it sticks out a little bit because every where else you return the found variable.
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @martinmr, and @pullrequest[bot])
posting/index.go, line 334 at r1 (raw file):
Previously, pullrequest[bot] wrote…
Would it be worth adding part of the comment from your PR description here just to help future readers of the code have that context? Otherwise it sticks out a little bit because every where else you return the
foundvariable.
Agreed. Please add a comment here.
Fixes #3803
Return found as false to avoid deleting index corresponding to a uid when the value doesn't match. For scalar values, after fingerprinting found is always true as values get fingerprinted to
math.MaxUint64. Hence we return found as false from this second check.This change is