Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a buffer size allocation in the JSON chunker that was taking up
a lot of time in the CPU profile while live loading, which had a huge
impact to live loading JSON data. I tried loading a JSON array of a
million objects structured like the following:
Before this change:
After this change:
Here's the CPU profile of the 5-minute live loading session 1-million edges (without this change), which shows the expensive GC path with (*jsonChunker).Chunk: cpu.pprof.gz.
This change is