Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix: prevent the HmacSecret from being logged #3734

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

gitlw
Copy link

@gitlw gitlw commented Jul 30, 2019

This change is Reviewable

@gitlw gitlw requested review from manishrjain and a team as code owners July 30, 2019 17:37
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gitlw and @manishrjain)


edgraph/config.go, line 71 at r1 (raw file):

func (opt Options) String() string {
	//return fmt.Sprintf()
	return fmt.Sprintf("{PostingDir:%s BadgerTables:%s BadgerVlog:%s WALDir:%s MutationsMode:%d "+

minor: add spaces after the colon to make it easier to read.

@gitlw gitlw merged commit d273ed6 into master Aug 2, 2019
@gitlw gitlw deleted the gitlw/fix_secret_logging branch August 2, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants