Rebuild reverse index before count reverse. #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this was causing issues before, but rebuilding the count reverse index depends on the reverse index, so I am chaning the logic to rebuild the reverse index first, followed by the count index. Also adding a comment to when the count reverse index is rebuilt.
|
Is there any chance you could have a test showing how this was previously broken and now behaves correctly? |
manishrjain
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
martinmr
commented
Jul 19, 2019
There was a problem hiding this comment.
@campoy Manish said it was a safe change so I'll submit it. I am going to keep working on indices so I'll look for more tests to make this feature more robust over the next few days.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this was causing issues before, but rebuilding the count
reverse index depends on the reverse index, so I am chaning the logic to
rebuild the reverse index first, followed by the count index.
Also adding a comment to when the count reverse index is rebuilt.
This change is