Vendor badger with the latest changes.

[martinmr]

Also update Dgraph to use the new badger Options API.

---

This change is 

[campoy]

Reviewed 38 of 38 files at r1.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @danielmai and @martinmr)

---

conn/node_test.go, line 38 at r1 (raw file):

func openBadger(dir string) (*badger.DB, error) {
	opt := badger.DefaultOptions(dir)

I would drop this function altogether and replace it with

badger.Open(badger.DefaultOptions(dir))

Or maybe just make this whole function body one line

---

dgraph/cmd/debug/run.go, line 746 at r1 (raw file):

		isWal = true
	}
	bopts := badger.DefaultOptions(dir).WithTableLoadingMode(options.MemoryMap).WithReadOnly(

I would write this a bit different and do one WithX per line, but it's totally stylistic so I won't push

---

dgraph/cmd/live/run.go, line 251 at r1 (raw file):

		var err error
		db, err = badger.Open(o)

Replace these lines with

	db, err := badger.Open(badger.DefaultOptions(opt.clientDir).
		WithTableLoadingMode(bopt.MemoryMap).
		WithSyncWrites(false))

---

ee/backup/run.go, line 224 at r1 (raw file):

		bo := badger.DefaultOptions(dir).WithSyncWrites(true).WithTableLoadingMode(
			options.MemoryMap).WithValueThreshold(1 << 10).WithNumVersionsToKeep(math.MaxInt32)
		db, err := badger.OpenManaged(bo)

Again, no need to declare bo as a variable, instead you can write

	db, err := badger.OpenManaged(badger.DefaultOptions(dir).
		WithSyncWrites(true).
		WithTableLoadingMode(options.MemoryMap).
		WithValueThreshold(1 << 10).
		WithNumVersionsToKeep(math.MaxInt32))

---

posting/list_test.go, line 1251 at r1 (raw file):

	opt := badger.DefaultOptions(dir)
	ps, err = badger.OpenManaged(opt)

ps, err := badger.OpenManaged(badger.DefaultOptions(dir))

---

raftwal/storage_test.go, line 50 at r1 (raw file):

func openBadger(dir string) (*badger.DB, error) {
	opt := badger.DefaultOptions(dir)
	return badger.Open(opt)

Same as in previous comment, this function is not really necessary

---

vendor/github.com/dgraph-io/badger/appveyor.yml, line 16 at r1 (raw file):

  GOVERSION: 1.8.3
  GOPATH: c:\gopath
  GO111MODULE: on

Why is this?

[martinmr]

Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @campoy and @danielmai)

---

conn/node_test.go, line 38 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

I would drop this function altogether and replace it with

badger.Open(badger.DefaultOptions(dir))

Or maybe just make this whole function body one line

Done.

---

dgraph/cmd/debug/run.go, line 746 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

I would write this a bit different and do one WithX per line, but it's totally stylistic so I won't push

Done.

---

dgraph/cmd/live/run.go, line 251 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

Replace these lines with

	db, err := badger.Open(badger.DefaultOptions(opt.clientDir).
		WithTableLoadingMode(bopt.MemoryMap).
		WithSyncWrites(false))

Done.

---

ee/backup/run.go, line 224 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

Again, no need to declare bo as a variable, instead you can write

	db, err := badger.OpenManaged(badger.DefaultOptions(dir).
		WithSyncWrites(true).
		WithTableLoadingMode(options.MemoryMap).
		WithValueThreshold(1 << 10).
		WithNumVersionsToKeep(math.MaxInt32))

Done.

---

posting/list_test.go, line 1251 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

ps, err := badger.OpenManaged(badger.DefaultOptions(dir))

Done.

---

raftwal/storage_test.go, line 50 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

Same as in previous comment, this function is not really necessary

Done.

---

vendor/github.com/dgraph-io/badger/appveyor.yml, line 16 at r1 (raw file):

Previously, campoy (Francesc Campoy) wrote…

Why is this?

I have no idea. I thought this was a change you made.

addressed review

[campoy]

Reviewed 9 of 9 files at r2.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @campoy and @danielmai)