-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs for /health endpoint & use application/graphql+- #3550
Conversation
4f4079a
to
faea3b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gitlw, @mangalaman93, @manishrjain, and @MichaelJCompton)
wiki/content/clients/index.md, line 819 at r1 (raw file):
```json { "version": "v1.0.12",
Use "v1.1.0", which will be a more realistic example within the docs. This version info in /health isn't in v1.0.12.
wiki/content/clients/index.md, line 825 at r1 (raw file):
Here,
uptime
is in nanosecond (typetime.Duration
in Go).
nanoseconds (plural)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danielmai, @gitlw, @manishrjain, and @MichaelJCompton)
wiki/content/clients/index.md, line 819 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
Use "v1.1.0", which will be a more realistic example within the docs. This version info in /health isn't in v1.0.12.
Done.
wiki/content/clients/index.md, line 825 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
nanoseconds (plural)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks like you've touched the docs in all the spots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gitlw and @manishrjain)
This change is