Allow partial restores and restoring different backup series. #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modfies the restore logic so that the restore only consideres the backups starting from the latest full backup. Future changes will allow users to specify which series of backups to restore but this is a first step which introduces a sane default.
Add a last_dir flag to the restore command that indicates to the restore that any backup directories created after should be ignored. This enables partial restores and restores of different backup series in backup directories that include multiple series of full and incremental backups.
golangcibot
reviewed
Jun 12, 2019
manishrjain
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Reviewed 3 of 6 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @martinmr)
ee/backup/handler.go, line 183 at r2 (raw file):
type manifestFile struct { path string
Just put path within the Manifest struct and mark so JSON won't marshal it.
Field int json:"-"
golangcibot
reviewed
Jun 13, 2019
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…-io#3547) Add a last_dir flag to the restore command that indicates to the restore that any backup directories created after should be ignored. This enables partial restores and restores of different backup series in backup directories that include multiple series of full and incremental backups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a last_dir flag to the restore command that indicates to the restore
that any backup directories created after should be ignored. This
enables partial restores and restores of different backup series in
backup directories that include multiple series of full and incremental
backups.
This change is