Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor in the sarama package to use its Kafka clients #3523

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Vendor in the sarama package to use its Kafka clients #3523

merged 1 commit into from
Jun 6, 2019

Conversation

gitlw
Copy link

@gitlw gitlw commented Jun 6, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@gitlw gitlw requested review from manishrjain and a team as code owners June 6, 2019 00:10
martinmr
martinmr approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

In the commit message, maybe include the govendor command(s) you ran to include these dependencies for reference.

Reviewed 347 of 347 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@gitlw gitlw merged commit 107789d into master Jun 6, 2019
@gitlw gitlw deleted the gitlw/vendor_sarama branch June 6, 2019 17:45
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
@dna2github
Vendor in Shopify/sarama to use its Kafka clients (dgraph-io#3523)
ca301a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmr martinmr martinmr approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitlw @martinmr