Support types in the bulk loader. #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlw
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)
edgraph/server.go, line 410 at r1 (raw file):
} glog.Infof("Got schema: %+v\n", result.Preds)
Log the whole result instead, since it might be useful to see the types as well.
martinmr
commented
Jun 10, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @gitlw and @manishrjain)
edgraph/server.go, line 410 at r1 (raw file):
Previously, gitlw (Lucas Wang) wrote…
Log the whole result instead, since it might be useful to see the types as well.
Done.
manishrjain
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
Reviewed 10 of 11 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gitlw)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes the loader tests in systest/ to query an instance of Dgraph backed by the results of the bulk loader. Currently only the results of the live loader were being verified.
This change is