Fix race condition in oracle.go #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we pass a pointer to a delta to a channel and then set the group checksums. This results in a race condition because the pointer is sent to multiple channels. This change changes the channel to send a delta instead of a pointer. This should fix this particular race condition.
martinmr
force-pushed
the
martinmr/fix-zero-race
branch
from
9096145
to
a9c8642
Compare
manishrjain
approved these changes
May 15, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
gitlw
approved these changes
May 15, 2019
There was a problem hiding this comment.
Reviewable status:
|
Do not observe any race condition in zero anymore. Ran flock overnight. |
|
Fixes zero data races in #3411 |
|
Thanks for checking @mangalaman93 |
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Currently, we pass a pointer to a delta to a channel and then set the group checksums. This results in a race condition because the pointer is sent to multiple channels. This change changes the channel to send a delta instead of a pointer. This should fix this particular race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we pass a pointer to a delta to a channel and then set the
group checksums. This results in a race condition because the pointer
is sent to multiple channels. This change changes the channel to send
a delta instead of a pointer. This should fix this particular race
condition.
This change is