Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in the Jaeger and prometheus exporters from open census #3322

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

gitlw
Copy link

@gitlw gitlw commented Apr 25, 2019

This change is Reviewable

@gitlw gitlw requested review from manishrjain and a team as code owners April 25, 2019 19:12
@gitlw gitlw force-pushed the gitlw/vendoring_oc_exporters branch from 968466d to 272c376 Compare April 25, 2019 19:40
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 22 of 22 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 22 of 22 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gitlw gitlw merged commit 80a2860 into master Apr 25, 2019
@gitlw gitlw deleted the gitlw/vendoring_oc_exporters branch April 25, 2019 23:39
gitlw pushed a commit that referenced this pull request Apr 26, 2019
gitlw pushed a commit that referenced this pull request Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants