Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the StartTs for the commit gRPC call #3228

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

gitlw
Copy link

@gitlw gitlw commented Mar 29, 2019

so that the client can verify the startTs in the response still matches their locally cached startTs


This change is Reviewable

@gitlw gitlw requested a review from a team April 2, 2019 00:50
Copy link
Contributor

@srfrog srfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@srfrog srfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gitlw gitlw merged commit dddadd3 into master Apr 2, 2019
@gitlw gitlw deleted the gitlw/populate_start_ts branch April 2, 2019 22:58
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants