Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when @recurse queries contain nested fields. #3182

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Mar 20, 2019

This change is Reviewable

@martinmr martinmr requested a review from a team March 20, 2019 20:48
Copy link
Contributor

@MichelDiz MichelDiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)


query/recurse.go, line 204 at r1 (raw file):

	for _, child := range sg.Children {
		if len(child.Children) > 0 {
			return x.Errorf("@recurse queries do not support nested predicates")

recurse queries do not allow nested predicates, they must be specified on one level.

@martinmr martinmr merged commit d84ab21 into master Mar 21, 2019
@martinmr martinmr deleted the martinmr/recurse-nested branch March 21, 2019 00:09
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants