-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk multi-shard DBs fix #3065
Bulk multi-shard DBs fix #3065
Conversation
…k import rather than just the preds actually contained in that DB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull)
dgraph/cmd/bulk/loader.go, line 246 at r2 (raw file):
m
rename this variable to something a bit more descriptive. m implies a map but we are using this more as a set.
Ideas: usedPreds, fullPreds, seenPreds or something like that.
dgraph/cmd/bulk/run.go, line 136 at r2 (raw file):
os.Exit(1) } else if _, err := os.Stat(opt.DataFiles); err != nil && os.IsNotExist(err) { fmt.Fprintf(os.Stderr, "Data path(%v) does not exist .\n", opt.DataFiles)
Remove the blank space between exist and the period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge after addressing @martinmr 's comments.
Reviewed 2 of 4 files at r2, 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @martinmr)
dgraph/cmd/bulk/loader.go, line 246 at r2 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
m
rename this variable to something a bit more descriptive. m implies a map but we are using this more as a set.
Ideas: usedPreds, fullPreds, seenPreds or something like that.
I used m because it matches ld.schema.m below.
dgraph/cmd/bulk/run.go, line 136 at r2 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
Remove the blank space between exist and the period.
Done.
Change summary: * Each shard's schema contains only the predicates found in that shard rather than all preds. * Test case for above fix. * More user-friendly "file not found" messages rather than stack traces when bulk schema or data paths incorrect.
Change summary: * Each shard's schema contains only the predicates found in that shard rather than all preds. * Test case for above fix. * More user-friendly "file not found" messages rather than stack traces when bulk schema or data paths incorrect.
Change summary:
Each shard's schema contains only the predicates found in that shard rather than all preds.
Test case for above fix.
More user-friendly "file not found" messages rather than stack traces when bulk schema or data paths invalid.
This change is