Change /commit endpoint to accept a list of preds. #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the commit endpoint accepted a list of keys. Now it accepts a map with two keys, one whose value represents the keys and the other represents the preds.
manishrjain
reviewed
Feb 15, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
|
Tested manually and added an extra test to ensure the endpoint works even if no list of preds is sent. |
martinmr
force-pushed
the
martinmr/http-commit-preds
branch
from
a02aaef
to
dc2f3d5
Compare
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Previously the commit endpoint accepted a list of keys. Now it accepts a map with two keys, one whose value represents the keys and the other represents the preds. The endpoint still accepts the old format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the commit endpoint accepted a list of keys. Now it accepts a
map with two keys, one whose value represents the keys and the other
represents the preds.
Fixes #3012
This change is