VerifyUid should wait for membership information #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed from Zero, instead of making a direct request to Zero.
manishrjain
added a commit
that referenced
this pull request
Feb 5, 2019
Switch verifyUid to rely upon the membership information being streamed from Zero, instead of making a direct request to Zero. This avoids a barrage of `ClusterInfoOnly` requests to Zero by the many mutation requests running concurrently in Alpha, particularly during live loading (where the live loader independently gets uids assigned from Zero).
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Switch verifyUid to rely upon the membership information being streamed from Zero, instead of making a direct request to Zero. This avoids a barrage of `ClusterInfoOnly` requests to Zero by the many mutation requests running concurrently in Alpha, particularly during live loading (where the live loader independently gets uids assigned from Zero).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch
verifyUidto rely upon the membership information being streamed from Zero, instead of making a direct request to Zero.This change is