-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the result of count(uid) to be assigned to a var. #2947
Conversation
Allow expressions of the form "f as count(uid)". When resolving the value of such a variable inside a math block it gets treated as a constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just remove the glog.Infof.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)
query/query.go, line 1505 at r1 (raw file):
} glog.Infof("value %v", int64(len(sg.DestUIDs.Uids)))
Don't add logs in query execution paths. They can get very expensive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain)
query/query.go, line 1505 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Don't add logs in query execution paths. They can get very expensive.
oops actually that was a debug check. thanks for noticing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain)
query/query.go, line 1505 at r1 (raw file):
Previously, srfrog (Gus) wrote…
oops actually that was a debug check. thanks for noticing
Done. Thanks for catching this, this was just a debug check.
Allow expressions of the form "f as count(uid)". When resolving the value of such a variable inside a math block it gets treated as a constant.
Allow expressions of the form "f as count(uid)".
When resolving the value of such a variable inside a math block it gets
treated as a constant.
This change is