Fix int/float conversion to bool

[srfrog]

This PR changes the logic in Convert to set int/float zero values as false when converting to bool. All other values will be true. Before this change, an int/float value of one (1) would convert to false bool.

Old behavior:

int: convert 1 to bool -> false
int: convert != 1 to bool -> true

float: convert 1 to bool -> false
float: convert != 1 to bool -> true

string: convert "" to bool -> error

New behavior:

int: convert 0 to bool -> false
int: convert != 0 to bool -> true

float: convert 0 to bool -> false
float: convert != 0 to bool -> true

string: convert "" to bool -> false

---

This change is 

[manishrjain]

This is a breaking change, which would affect everyone using bools.

Can you add tests for this change?

[manishrjain]

One comment. Can you also fix the empty string -> bool conversion?

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @srfrog and @gitlw)

---

types/conversion_test.go, line 218 at r2 (raw file):

		{in: Val{Tid: StringID, Value: []byte("False")}, out: Val{Tid: BoolID, Value: false}},
		{in: Val{Tid: StringID, Value: []byte("srfrog")}, fail: true},
		{in: Val{Tid: StringID, Value: []byte("")}, fail: true},

Shouldn't this be false? Empty string is the default in string. False is the default in bool.

[srfrog]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @gitlw)

---

types/conversion_test.go, line 218 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Shouldn't this be false? Empty string is the default in string. False is the default in bool.

Done.

[manishrjain]

Try to make tests go in one line.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain)